Avoid type-unsafe use of 'head' #34
PeterRugghaskell.yml
on: pull_request
Run HLint on the QuickCheck Verification Engine codebase
11s
Build the QuickCheck Verification Engine
2m 35s
Annotations
20 warnings
|
Run HLint on the QuickCheck Verification Engine codebase:
src/InstrCodec.hs#L36
Warning in module InstrCodec: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE MultiParamTypeClasses #-}" ▫︎ Note: may require `{-# LANGUAGE ConstrainedClassMethods #-}` adding to the top of the file Extension MultiParamTypeClasses is implied by FunctionalDependencies
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/InstrCodec.hs#L129
Warning in unscatter in module InstrCodec: Use replicate ▫︎ Found: "take lsb $ repeat False" ▫︎ Perhaps: "replicate lsb False"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/Main.hs#L280
Suggestion in main in module Main: Move brackets to avoid $ ▫︎ Found: "(str =~ (fromMaybe \".*\" incReg))\n && (not $ str =~ fromMaybe \"a^\" excReg)" ▫︎ Perhaps: "(str =~ (fromMaybe \".*\" incReg))\n && not (str =~ fromMaybe \"a^\" excReg)"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/Main.hs#L280
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "str =~ (fromMaybe \".*\" incReg)" ▫︎ Perhaps: "str =~ fromMaybe \".*\" incReg"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/Main.hs#L378
Suggestion in main in module Main: Use void ▫︎ Found: "f t >> return ()" ▫︎ Perhaps: "void (f t)"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/Main.hs#L378
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "(numTests <$>)\n . (doCheck (wrapTest <$> (T.genTest testParams template)))" ▫︎ Perhaps: "(numTests <$>)\n . doCheck (wrapTest <$> (T.genTest testParams template))"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/Main.hs#L378
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "wrapTest <$> (T.genTest testParams template)" ▫︎ Perhaps: "wrapTest <$> T.genTest testParams template"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/Main.hs#L383
Warning in main in module Main: Use fmap ▫︎ Found: "liftM" ▫︎ Perhaps: "fmap"
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/MainHelpers.hs#L1
Warning in module QuickCheckVEngine.MainHelpers: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE TypeSynonymInstances #-}" ▫︎ Note: Extension TypeSynonymInstances is implied by FlexibleInstances
|
|
Run HLint on the QuickCheck Verification Engine codebase:
src/QuickCheckVEngine/MainHelpers.hs#L88
Warning in showAnnotatedTrace in module QuickCheckVEngine.MainHelpers: Use snd ▫︎ Found: "\\ (a, b) -> b" ▫︎ Perhaps: "snd"
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L79
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L80
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L81
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L87
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L88
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L89
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L95
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L96
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L97
In the use of ‘head’
|
|
Build the QuickCheck Verification Engine:
src/RISCV/RV_CSRs.hs#L196
In the use of ‘head’
|