Add bio array tests #101
Add bio array tests #101
Conversation
There was a problem hiding this comment.
Hi @graemevissers ,
Thank you for your contributions. everything looks fine. I just have a single comment on your last test. It would be awesome if you could further isolate that test (see my comment). Otherwise, cool stuff. We can get this merged soon.
| ) | ||
|
|
||
| testCase "toCompositionVector" (fun () -> | ||
| let testCompVec = Array.zeroCreate 26 |
There was a problem hiding this comment.
In this test you are also dependent on BioItem.symbol working as expected. It would make the test more isolated if you initialize the test composition vector without being dependent on other code (e.g. using the correct characters in lines 182-184).
There was a problem hiding this comment.
To add changes to this PR, the only thing you have to do is add new commits to your branch, they will be automatically added to the PR.
There was a problem hiding this comment.
Hi @kMutagene,
Thanks for the suggestions. I updated the code to no longer be dependent on BioItem.symbol and committed.
| Expect.floatClose | ||
| Accuracy.medium // High accuracy was not passing test | ||
| (testProt |> BioArray.toAverageMass) | ||
| // Masses obtained from University of Washington Proteomics Resource https://proteomicsresource.washington.edu/protocols06/masses.php |
There was a problem hiding this comment.
I also like that you included sources here, so when we have to revisit these tests we have the references in the code.
|
Referencing #30 to track progress |
Add bio array tests (CSBiology#101)
Add unit tests to BioArray testList in BioCollectionsTests module
Changes
Add testCases:
to testList BioArray in BioCollectionsTests module.
Description
This contribution adds seven unit tests to the BioCollectionsTests module, and I plan on adding similar tests to other testLists in that module. These unit tests all seem to be passing, but this is my first contribution to BioFSharp, so please let me know if there are ways to improve my contributions.
[Required] please make sure you checked that