Add end flip with state comparator test #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/CPP-KT/bimap-NikitaMsln/pull/1/commits/5c30a7d2ccc81c1f7dc071197c48929768602cca
На этом коммите моя бимапа представляла собой 2 интрузив сета с разными конечными нодами, а ноды между ними были разделяемым.
Когда я делал флип, происходил статик каст из элемента сета одного тега в другой, что просто сдвигало указатель.
Когда происходил флип энда, если компаратор был разделяемым, то так как порядок наследования ноды от элементов сета совпадал с порядком хранения сетов, после флипа на энд указатель попадал в нужный энд другого сета, но если делать флип энд с хранимым компаратором, то такого трюка не выйдет.