Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage to 100% #929

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Coverage to 100% #929

merged 2 commits into from
Oct 7, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 7, 2023

remove old code since all arguments are quoted now and the code was not being used, add coverage exclusion on some code that should never be executed and add an additional test

phlptp and others added 2 commits October 7, 2023 07:21
…ot being used, add coverage exclusion on some code that should never be executed and add an additional test
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
include/CLI/StringTools.hpp 100.00% <ø> (ø)
include/CLI/impl/StringTools_inl.hpp 100.00% <ø> (+4.29%) ⬆️
include/CLI/impl/Validators_inl.hpp 100.00% <ø> (+0.50%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@phlptp phlptp merged commit dd4bbd8 into CLIUtils:main Oct 7, 2023
49 checks passed
@phlptp phlptp deleted the coverage branch October 7, 2023 15:20
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants