Implement adding/ removing non-steam games from card and improve viewing games on card #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally looks good. I will fix up any small problems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so here's my idea for ui. you can mess with it however you want. I made the games list it's own modal that is now scrollable (more of an overlay but i think it looks nice for scorlling) and can be opened directly from the card action menu or within the edit card modal itself. In the edit card modal theres an accordian panel (can be opened/ closed) which lists all non-steam games with checkboxes allowing for quickly adding/ removing multiple games without having to popup menus and select one at a time. theres also text box to allow for filtering the list down and making it even more manageable. lastly, when making changes to the non steam games it will show how many are going to be added and deleted, and if you open the game list modal from within the editor it will also show games to be addeed in green and removals in red.
Also i added a few files for types as well as audio module that you might wanna move around. I've been trying to get some of that into dfl for a while but still waiting on that, so in the future you should just be able to import from there.