Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Workflow #101

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Deployment Workflow #101

merged 2 commits into from
Nov 5, 2024

Conversation

shanice-skylight
Copy link
Collaborator

PULL REQUEST

Summary

This PR will add a workflow that is triggered by the repo dibbs-query-connector. See explanation of each step of the workflow below:

  1. Step named Checkout code uses the actions/checkout@v4 action to check out the source code of the repository.
  • The ref parameter with the value ${{ github.event.client_payload.sha }} will check out the specific commit or branch referenced in the sha field of the client_payload object of the triggering event. This allows the workflow to operate on the exact code state associated with the triggering event
  1. Step named Extract Service Name & Version will extract and display the service name and version values from the client_payload object of the triggering event. These values are passed when the workflow is manually triggered and are stored in the payload for use in downstream steps.
    ***Note: The intent is for this to automatically trigger but starting with manual for testing purposes ***

  2. The remaining steps are pulled from the workflow named awsDeployment. The end result is the image for Query Connector is pulled from the repo dibbs-query-connector and deployed to the EKS pod

Related Issue

Fixes Issue 79

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here @shanice-skylight! Left a couple question below, but not going to block anything because I haven't been looped into this work for the last couple days.

run: |
# Parse the service name from the payload
service_name=${{ github.event.client_payload.service }}
echo "Service Name: $service_name"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are parsing out service name here then this is really a general deployment workflow that can deploy any service not just the Query Connector. However the current workflow name, QC Target Workflow, suggestions things are scoped more narrowly to just the Query Connector. Am I following this correctly? Would it make sense to update the name?

outputs:
tf_env: ${{ steps.set-environment.outputs.tf_env }}
steps:
- name: Checkout code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why we need to checkout code from dibbs-query-connector if the service name and version are passed in separately.

@shanice-skylight shanice-skylight merged commit f8de382 into main Nov 5, 2024
3 checks passed
@shanice-skylight shanice-skylight deleted the shanice/deployment-workflow branch November 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update QC's CD
4 participants