Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9822] Resolve issues with plotting anchors properly on the x axis #1714

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Nov 22, 2024

[DEV-9822] Resolve issues with plotting anchors properly on the x axis

Anchor lines weren't plotting at the correct location. This accounts for the xScale.bandwidth() / 2 (middle point of linear axis tick) when the scale type is either date (linear) or categorical (linear).

Testing Steps

  • Run yarn storybook
  • Open /story/components-templates-chart-anchors--anchor-date-linear

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Before
Screen Shot 2024-11-22 at 11 31 22 AM

After
Screen Shot 2024-11-22 at 11 41 13 AM

Additional Notes

@adamdoe adamdoe marked this pull request as ready for review November 22, 2024 20:21
@Atash3000
Copy link
Collaborator

Anchor lines does not work with filters. they are staying there all the time even filter value for dates are different than entered on anchor.if it is normal behavior then other things works correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants