Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9859] Improve mobile data table font sizes #1713

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jayb
Copy link
Collaborator

@jayb jayb commented Nov 22, 2024

[DEV-9859]

This does three things:

  1. Changes the mobile breakpoint for displaying mobile data table font sizes from 768px to 576px so desktop font sizes will be used in the DFE center column
  2. Reduces font size of mobile table headers, increases size of mobile cells
  3. Improves layout of sorting triangles on mobile

Testing Steps

View some charts with data tables on all screens sizes.

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Before:

Screenshot 2024-11-22 at 1 31 44 PM

After:

Screenshot 2024-11-22 at 1 32 04 PM

Additional Notes

There is a larger data table font refactor coming from the UX team, this PR just makes some interim improvements.

@jayb jayb requested a review from Mgetz10 November 22, 2024 18:38
@jayb jayb merged commit 12a6412 into dev Nov 22, 2024
1 check passed
@jayb jayb deleted the fix/DEV-9859-mobile-table-fonts branch November 22, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants