-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dev 4215h #1707
Feature/dev 4215h #1707
Conversation
@@ -244,17 +244,17 @@ const DataTable = (props: DataTableProps) => { | |||
</MediaControls.Section> | |||
) | |||
} | |||
const getClassNames = (): string => { | |||
const isBrushActive = config?.brush?.active && config.legend.position !== 'bottom' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
Consider organizing the class names in an array and returning the result. This can improve readability and maintainability:
const classes = []
if (logic) classes.push('class-name')
if (!logic) classes.filter(c => c !== 'class-name')
return classes.join(' ')
This approach makes the class logic easier to follow, especially when dealing with conditional class assignments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Nice work! This is working for me in the editor. I appreciate the extra detail on adding variable names in and updating the functions. |
[Replace With Ticket Number]
Testing Steps
Select Chart Type: Select the chart to a Bar, Line, or Combo type.
Select Scale Type: Choose the "Date or Time scale" option for the chart.
Configure Time Scale: Adjust the time scale settings as needed.
Enable Brush Slider:
On the Date Category Panel, locate a new checkbox labeled "Brush Slider".
Check this box to enable the Brush Slider. A brush slider should appear below the charts.
Adjust Brush Slider:
Drag the corners of the brush slider to precisely adjust the scale of the bars or lines in the chart.
Update Legend Position:
Change the legend position to the bottom of the chart and verify that it does not overlap with the brush slider.
Adjust Tick Rotation:
Modify the rotation of the ticks on the axis to ensure there is no overlap with the brush slider.
Activate Filters:
Turn on any filters. The brush slider should reset to its initial state once the filters are activated.
Self Review
Screenshots (if applicable)
Additional Notes