Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement [DEV 9860] Improve map spacing #1705

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

Mgetz10
Copy link
Collaborator

@Mgetz10 Mgetz10 commented Nov 20, 2024

DEV-9860

The OPHDST team would like to improve the spacing between elements (legend, data table, subtext, etc.) that appear below maps. We previously did this for charts and would like to take a pass for maps.

NOTE

Territories will be handled in a separate PR

Testing Steps

  1. Create or view map with legend
  2. Observe there are no large conspicuous gaps

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Before

Screenshot 2024-11-20 at 2 47 01 PM

After

Screenshot 2024-11-21 at 10 03 04 AM

@Mgetz10 Mgetz10 changed the base branch from main to dev November 20, 2024 19:40
@Mgetz10 Mgetz10 marked this pull request as draft November 20, 2024 19:40
@Mgetz10 Mgetz10 force-pushed the enhancement/dev-9860_improve-map-spacing branch from 8b9a0d3 to c674398 Compare November 20, 2024 19:48
@Mgetz10 Mgetz10 marked this pull request as ready for review November 20, 2024 20:42
@Mgetz10 Mgetz10 merged commit 8749c01 into dev Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants