[DEV-9840] add confidence intervals to line charts #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdoe
force-pushed
the
feature/DEV-9840
branch
from
37f7081
to
64f55a3
Compare
Test Steps: - [ ] Run yarn storybook - [ ] Navigate to /story/components-templates-chart--line-chart-confidence-intervals - Expose series.confidenceIntervals to line charts - Add <AreaClosed /> component to line charts to show confidence intervals - Add story for line charts with confidence intervals
adamdoe
force-pushed
the
feature/DEV-9840
branch
from
e255594
to
41e2f90
Compare
adamdoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEV-8940] add confidence intervals to line charts
yarn storybook/story/components-templates-chart--line-chart-confidence-intervalsCI's are added under the series level as a repeating field. This decision was made because not all CI's will be uniform. The repeater allows multiple confidence intervals to be added to the line if needed (ie. 25/50/95). We're re-using the pattern from Forecasting charts to keep the config lean
series.confidenceIntervalssince its the same feature.Testing Steps
Self Review
Screenshots (if applicable)
Additional Notes