Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement [dev-9440] loading states on dropdowns #1668

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

joshlacey
Copy link
Collaborator

[Replace With Ticket Number]

Testing Steps

testing instructions are in the ticket and require an api connection for the api dropdowns.

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@joshlacey joshlacey added this to the 4.24.12 milestone Nov 11, 2024
Copy link
Collaborator

@Matt-DiPaolo Matt-DiPaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and functioning.

@joshlacey joshlacey added the Hold label Nov 13, 2024
@joshlacey joshlacey removed the Hold label Nov 20, 2024
@joshlacey joshlacey force-pushed the enhancement/dev-9440-loading-states branch from e0b07cc to b085961 Compare November 20, 2024 16:27
@joshlacey joshlacey merged commit db15f1f into dev Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants