Fix: [DEV-9001] date format for table #1666
Conversation
joshlacey
changed the title
|
|
||
| if (isDateTime && !config.table.dateDisplayFormat) { | ||
| cellValue = formatDate(config.xAxis?.dateDisplayFormat, parseDate(config.xAxis?.dateDisplayFormat, labelValue)) | ||
| } |
There was a problem hiding this comment.
make this more readable:
if (isDateTime) { const dateDisplayFormat = config.table?.dateDisplayFormat || config.xAxis?.dateDisplayFormat; cellValue = formatDate(dateDisplayFormat, parseDate(dateDisplayFormat, labelValue) }
There was a problem hiding this comment.
This comment was for this and the if statement above it. You can handle both with these couple lines.
There was a problem hiding this comment.
Can you explain more please? I did not understood the issue here
There was a problem hiding this comment.
code is readable. should we remove if statement or add alll logic here : if ((column === config.xAxis?.dataKey && type === 'date') || (type === 'date-time' && type === 'continuous')) {
Atash3000
changed the title
Atash3000
changed the title
| : labelValue | ||
| cellValue = | ||
| config.xAxis?.type === 'continuous' ? formatNumber(runtimeData[row][column], 'bottom', false, config) : labelValue | ||
| let { type, dateDisplayFormat } = config.xAxis || {} |
| cellValue = | ||
| config.xAxis?.type === 'continuous' ? formatNumber(runtimeData[row][column], 'bottom', false, config) : labelValue | ||
| let { type, dateDisplayFormat } = config.xAxis || {} | ||
| let dateFormat = config.table?.dateDisplayFormat || dateDisplayFormat |
| cellValue = formatNumber(runtimeData[row][column], 'bottom', false, config) | ||
| } else { | ||
| cellValue = labelValue | ||
| } |
There was a problem hiding this comment.
this logic works otherwise, just change those above consts since those aren't variable.
[Replace With Ticket Number]
Testing Steps
Open Bar/Line/Combo charts.
Switch to Date time or Date scale
Enter date format for text field "Data Table date display format" which updates only data table if entered.
The data table date format should be changed entered date format.
Self Review
Screenshots (if applicable)
Additional Notes