Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures Category Values Order Holds on Filter Change #1663

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Ensures Category Values Order Holds on Filter Change #1663

merged 1 commit into from
Nov 7, 2024

Conversation

mpallansch
Copy link
Collaborator

DEV-9644

Ensures Category Values Order Holds on Filter Change

Testing Steps

  1. Get config from ticket, copy locally to example in dashboard project
  2. Run dashboard project, edit first map in the dashboard
  3. In Legend section, change category values order
  4. Change filter dropdown in preview
  5. Change filter dropdown back, ensure change made to category values order was not erased

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

@adamdoe
Copy link
Collaborator

adamdoe commented Nov 7, 2024

LGTM!

@adamdoe adamdoe merged commit acbd802 into dev Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdoe adamdoe Awaiting requested review from adamdoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpallansch @adamdoe