Handle existing mda session being None #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for catching this and for the PR. All of this is being completely overhauled in the upcoming 4.2 release #501 which will also fix this issue. I'm happy to accept this and put out a small bugfix for 4.1 though! Was this only happening after installing MDAnalysis / python packages for the first time? Was it fixed after restarting Blender maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a MD file for the first time with molecular nodes 4.1.0 as well as 4.1.0, I got an error that existing_session is None here:
MolecularNodes/molecularnodes/io/parse/mda.py
Line 438 in 33a0785
Not sure where this is coming from but this fixes the issue