Bugfix: Uploaded icons were not handled correct in IconTextLampPlugin…

… and IconTextPlugin.
BlueAndi · Aug 15, 2024 · f348bc8 · f348bc8
1 parent 31e8fb9
commit f348bc8
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/lib/IconTextLampPlugin/src/IconTextLampPlugin.cpp b/lib/IconTextLampPlugin/src/IconTextLampPlugin.cpp
@@ -248,7 +248,25 @@ bool IconTextLampPlugin::setTopic(const String& topic, const JsonObjectConst& va
         {
             String fullPath = jsonFullPath.as<String>();
 
-            isSuccessful = loadIcon(fullPath);
+            /* Clear always the icon indpended whether its requested by user.
+             * In case of an uploaded new icon, clearing will close the image
+             * file and makes it possible to overwrite the file.
+             */
+            clearIcon();
+
+            if (false == fullPath.isEmpty())
+            {
+                /* Rename uploaded icon by removing the file extension for temporary files. */
+                String iconFullPathWithoutTmp = fullPath.substring(0, fullPath.length() - strlen(FILE_EXT_TMP));
+
+                FILESYSTEM.rename(fullPath, iconFullPathWithoutTmp);
+
+                isSuccessful = loadIcon(iconFullPathWithoutTmp);
+            }
+            else
+            {
+                isSuccessful = true;
+            }
         }
     }
     else

diff --git a/lib/IconTextPlugin/src/IconTextPlugin.cpp b/lib/IconTextPlugin/src/IconTextPlugin.cpp
@@ -175,7 +175,25 @@ bool IconTextPlugin::setTopic(const String& topic, const JsonObjectConst& value)
         {
             String fullPath = jsonFullPath.as<String>();
 
-            isSuccessful = loadIcon(fullPath);
+            /* Clear always the icon indpended whether its requested by user.
+             * In case of an uploaded new icon, clearing will close the image
+             * file and makes it possible to overwrite the file.
+             */
+            clearIcon();
+
+            if (false == fullPath.isEmpty())
+            {
+                /* Rename uploaded icon by removing the file extension for temporary files. */
+                String iconFullPathWithoutTmp = fullPath.substring(0, fullPath.length() - strlen(FILE_EXT_TMP));
+
+                FILESYSTEM.rename(fullPath, iconFullPathWithoutTmp);
+
+                isSuccessful = loadIcon(iconFullPathWithoutTmp);
+            }
+            else
+            {
+                isSuccessful = true;
+            }
         }
     }
     else