IconTextLampPlugin and IconTextPlugin /text topic wrongly removed the…

… image file.
BlueAndi · Aug 15, 2024 · 9a8dc1d · 9a8dc1d
1 parent 80aa173
commit 9a8dc1d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 38 deletions.
diff --git a/lib/IconTextLampPlugin/src/IconTextLampPlugin.cpp b/lib/IconTextLampPlugin/src/IconTextLampPlugin.cpp
@@ -188,25 +188,7 @@ bool IconTextLampPlugin::setTopic(const String& topic, const JsonObjectConst& va
         {
             String iconFullPath = jsonIconFullPath.as<String>();
 
-            /* Clear always the icon indpended whether its requested by user.
-             * In case of an uploaded new icon, clearing will close the image
-             * file and makes it possible to overwrite the file.
-             */
-            clearIcon();
-
-            if (false == iconFullPath.isEmpty())
-            {
-                /* Rename uploaded icon by removing the file extension for temporary files. */
-                String iconFullPathWithoutTmp = iconFullPath.substring(0, iconFullPath.length() - strlen(FILE_EXT_TMP));
-
-                FILESYSTEM.rename(iconFullPath, iconFullPathWithoutTmp);
-
-                isSuccessful = loadIcon(iconFullPathWithoutTmp);
-            }
-            else
-            {
-                isSuccessful = true;
-            }
+            isSuccessful = loadIcon(iconFullPath);
         }
     }
     else if (0U != topic.startsWith(String(TOPIC_LAMP) + "/"))

diff --git a/lib/IconTextPlugin/src/IconTextPlugin.cpp b/lib/IconTextPlugin/src/IconTextPlugin.cpp
@@ -145,25 +145,7 @@ bool IconTextPlugin::setTopic(const String& topic, const JsonObjectConst& value)
         {
             String iconFullPath = jsonIconFullPath.as<String>();
 
-            /* Clear always the icon indpended whether its requested by user.
-             * In case of an uploaded new icon, clearing will close the image
-             * file and makes it possible to overwrite the file.
-             */
-            clearIcon();
-
-            if (false == iconFullPath.isEmpty())
-            {
-                /* Rename uploaded icon by removing the file extension for temporary files. */
-                String iconFullPathWithoutTmp = iconFullPath.substring(0, iconFullPath.length() - strlen(FILE_EXT_TMP));
-
-                FILESYSTEM.rename(iconFullPath, iconFullPathWithoutTmp);
-
-                isSuccessful = loadIcon(iconFullPathWithoutTmp);
-            }
-            else
-            {
-                isSuccessful = true;
-            }
+            isSuccessful = loadIcon(iconFullPath);
         }
     }
     else if (0U != topic.equals(TOPIC_ICON))