-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge adding tox into main #160
base: main
Are you sure you want to change the base?
Conversation
[CHORE] ⬆ IUpdate Fork
Any news on a potential review on this please ? @LadyChristina |
Hi @MokhFn, thanks for the nudge, as I had taken a look at this last month but forgot to follow up. My issue was that I was getting some errors while running this locally, so I wasn't sure if there was sth wrong with the PR or my local tox configuration. But I also didn't know about tox before so it would help if you could explain why it's useful to have? If we go for it, it would be useful to include some instructions for how to use it (e.g. in the README), as I assume other people may not be familiar with it either |
No problem @LadyChristina, and thanks for reaching back. Where it adds a lot of value here, is enabling us to setup specific and different environments for each step of the pipeline. Another, important use case too, is testing our package within multiple python versions, which is easier to do with tox. For more details, you can maybe check the tox doc, or this article. Finally, there is also nox, which is a more pythonic way compared to tox (basically tox, but without the tox.ini file, instead, we use a noxfile.py). Now, for the local issues, i just added a requirement for tox installation. Could you retry and let me know please ? If it doesn't fix your issues, could you publish details ? On another hand, doc updates are noted, will be updated once the issues are resolved. |
All Submissions:
Description
This PR makes tests more automated as they run via tox.
This introduces tox environments, for future uses, such as automated code reformatting, code analysis, releases, doc updates, etc ... within isolated environments.