Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update semantic-release configuration for consistency and correct versioning #38

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Bjarten
Copy link
Owner

@Bjarten Bjarten commented Nov 11, 2024

Summary

This PR addresses configuration inconsistencies and improves the semantic-release setup for the early-stopping-pytorch package. Changes were made to ensure proper versioning, tagging, and build process alignment, which should eliminate the warnings seen in recent CI runs.

Changes Made:

  1. Updated pyproject.toml:

    • Corrected the version_variable to match the actual package path.
    • Consolidated the tag_format under [tool.semantic_release].
    • Added version_toml to synchronize version updates with pyproject.toml.
    • Set upload_to_pypi to false for now, as per project requirements.
  2. Workflow Update (.github/workflows/release.yml):

    • Simplified permissions to contents: write for better security.
    • Retained workflow_dispatch trigger for manual release control.

Rationale

These changes ensure that versioning is consistently managed and that warnings are minimized, improving CI/CD pipeline efficiency. The configuration should now support smoother releases with semantic versioning and prevent potential issues with incorrect tag formats or misconfigured variables.

@Bjarten Bjarten merged commit 0faabd0 into main Nov 11, 2024
5 checks passed
@Bjarten Bjarten deleted the fix/versioning branch November 11, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant