Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate version definitions and update release workflow #30

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Bjarten
Copy link
Owner

@Bjarten Bjarten commented Oct 16, 2024

This pull request consolidates version definitions and improves the release workflow to streamline the versioning and publishing processes. The changes are part of an effort to improve maintainability and ensure the workflows are efficient and modular.

Changes Made:

  • Consolidated Version Management:

    • Removed duplicate version definitions to maintain a single source of truth. The version is now only defined in early_stopping_pytorch/__init__.py to avoid conflicts.
    • Removed the version field from pyproject.toml, as python-semantic-release handles versioning automatically.
  • Updated Release Workflow:

    • Improved the Create New Release workflow by separating the release process from the publishing process.
    • The release process now handles version bumping, tagging, and creating GitHub releases via python-semantic-release.
  • New Publish Workflow:

    • A dedicated workflow now handles publishing the package to PyPI when a new version tag is pushed.
    • This ensures a clear separation of responsibilities between creating releases and publishing to PyPI, reducing complexity.

@Bjarten Bjarten merged commit e79817a into main Oct 16, 2024
5 checks passed
@Bjarten Bjarten deleted the fix/release-workflow branch October 16, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant