Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/firmware/bip85: rename BIP85 and add BIP85_ln() #90

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

benma
Copy link
Contributor

@benma benma commented Feb 20, 2024

Access to the BIP85 sub-apps BIP39 and LN according to BitBoxSwiss/bitbox02-firmware#1179.

Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

if !ok {
return errp.New("unexpected response")
}
return nil
}

// BIP85AppLN invokes the BIP85-LN workflow on the device, returning 16 bytes of derived eentropy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: eentropy

@benma benma merged commit 3ff3e90 into BitBoxSwiss:master Feb 20, 2024
3 checks passed
@benma benma deleted the bip85 branch February 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants