Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware/eth: typos #85

Merged
merged 1 commit into from
Oct 17, 2023
Merged

firmware/eth: typos #85

merged 1 commit into from
Oct 17, 2023

Conversation

benma
Copy link
Contributor

@benma benma commented Aug 31, 2023

No description provided.

@benma benma requested a review from Beerosagos August 31, 2023 13:24
Beerosagos
Beerosagos approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK!
Could you fix also return nil, errp.Newf("float64 is not an uint: %v", v) at line 432? :)

@benma benma merged commit 16d670c into BitBoxSwiss:master Oct 17, 2023
3 checks passed
@benma benma deleted the eip712 branch October 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beerosagos Beerosagos Beerosagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benma @Beerosagos