btc: verify and return silent payment outputs #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
sp
branch
3 times, most recently
from
005c709
to
387f82a
Compare
Silent Payment outputs are generated and returned by the firmware to be integrated into a transaction. This commit verifies the correctness of the generated output using a DLEQ proof and returns the output. The DLEQ verificaiton function is a quick port of https://github.com/BlockstreamResearch/secp256k1-zkp/blob/6152622613fdf1c5af6f31f74c427c4e9ee120ce/src/modules/ecdsa_adaptor/dleq_impl.h#L129 A DLEQ (discrete log equivalence) proof proves that the discrete log of P1 to the secp256k1 base G is the same as the discrete log of P2 to another base.
NickeZ
reviewed
Sep 17, 2024
| @@ -15,7 +15,7 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.34.2 | |||
| // protoc v5.27.1 | |||
| // protoc v3.21.12 | |||
There was a problem hiding this comment.
We are using an older version of protoc, which sounds weird, but I guess it doesn't matter as the output is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silent Payment outputs are generated and returned by the firmware to be integrated into a transaction. This commit verifies the correctness of the generated output using a DLEQ proof and returns the output.
The DLEQ verificaiton function is a quick port of
https://github.com/BlockstreamResearch/secp256k1-zkp/blob/6152622613fdf1c5af6f31f74c427c4e9ee120ce/src/modules/ecdsa_adaptor/dleq_impl.h#L129
A DLEQ (discrete log equivalence) proof proves that the discrete log of P1 to the secp256k1 base G is the same as the discrete log of P2 to another base.