Add back the condition_variable based LockedQueue for low-thread setups #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ch4rr0 I put a hardcoded cut at 16 threads, since I see CV scaling great at least to that concurrency for my purposes. i am open to suggestions on improving the logic on when to use CV vs MC. |
|
Any feedback yet? |
|
I'll check it out today, Igor. I apologize for the delay. |
|
Thanks for the PR Igor, and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On small thread count, the polling LockedQueue add substantial overhead to bowtie2,
so we revert back to using the lightweight condition_variable based solution there.
See #465 for details.
We keep the polling, lock-free version for higher thread counts, to avoid excessive contention on the lock.
See #437 for details.