Refactoring Custom Views #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CheckableLInearLayout` is now responsible for all interaction with the wrapped `CheckBox`. `BaseballCardView` and `HeaderView` no longer extend `CheckableLinearLayout` and only manage their own `TextView`s.
codeguru42
force-pushed
the
android/custom-views
branch
from
08b5d20
to
20ee357
Compare
Conflicts: gradle/android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardListWithDataTest.java
|
Currently |
codeguru42
force-pushed
the
android/custom-views
branch
from
2945320
to
067ec8c
Compare
# Conflicts: # gradle/android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardDetailsPartialInputTest.java # gradle/android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardDetailsTest.java # gradle/android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardListWithDataTest.java # gradle/android/src/androidTest/java/bbct/android/common/activity/test/FilterCardsTest.java # gradle/android/src/androidTest/java/bbct/android/common/layout/test/BaseballCardDetailsLayoutTest.java # gradle/android/src/androidTest/java/bbct/android/common/layout/test/FilterCardsLayoutTest.java # gradle/android/src/androidTest/java/bbct/android/common/test/BBCTTestUtil.java # gradle/android/src/main/java/bbct/android/common/activity/FilterCards.java # gradle/android/src/main/java/bbct/android/common/activity/MainActivity.java # gradle/android/src/main/res/layout/filter_cards.xml
# Conflicts: # gradle/android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardListWithDataTest.java
Don't need to find the `CheckBox` child
# Conflicts: # android/src/androidTest/java/bbct/android/common/activity/test/FilterCardsTest.java
codeguru42
force-pushed
the
android/custom-views
branch
from
12d49b9
to
e906302
Compare
# Conflicts: # android/src/main/java/bbct/android/common/activity/MainActivity.java # android/src/main/res/layout/baseball_card.xml # android/src/main/res/layout/list_header.xml
# Conflicts: # android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardDetailsWithDataTest.java # android/src/androidTest/java/bbct/android/common/activity/test/FilterCardsTest.java # android/src/androidTest/java/bbct/android/common/functional/test/survey/Survey2DialogTest.java # android/src/androidTest/java/bbct/android/common/layout/test/FilterCardsLayoutTest.java # android/src/androidTest/java/bbct/android/common/test/BBCTTestUtil.java # android/src/main/java/bbct/android/common/activity/BaseballCardDetails.java # android/src/main/java/bbct/android/common/activity/BaseballCardList.java # android/src/premium/java/bbct/android/premium/provider/PremiumSQLHelper.java
# Conflicts: # android/src/androidTest/java/bbct/android/common/activity/test/BaseballCardListWithDataTest.java # android/src/androidTest/java/bbct/android/common/activity/test/FilterCardsTest.java # android/src/androidTest/java/bbct/android/common/test/BBCTTestUtil.java # android/src/main/java/bbct/android/common/activity/FilterCards.java # android/src/main/java/bbct/android/common/provider/BaseballCardAdapter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.