Sync SiegeEvent fields/props #999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodrigz
force-pushed
the
916-sync-siegeevent-fields
branch
from
7599e18
to
ce74a82
Compare
brodrigz
force-pushed
the
916-sync-siegeevent-fields
branch
from
2e20fa5
to
b99a34b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SiegeEvent fields and props not synced
What is the new behavior?
Resolves #917
Resolves #916
Other information
All props and fields synced and passing tests
SettlementRegistry had to be changed in order for AutoSync to work with SiegeEvent.BesiegedSettlement and this still needs to be properly tested
Still need to do commands and ClientDoesNothing tests