Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CharacterObject Lifetime #986

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

EgardA
Copy link
Contributor

@EgardA EgardA commented Oct 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

No lifetime

What is the new behavior?

Resolves #845

Other information

Did not find anywhere this gets deleted.

@EgardA EgardA self-assigned this Oct 2, 2024
/// Lifetime Patches for CharacterObjects
/// </summary>
[HarmonyPatch]
internal class CharacterObjectLifetimePatches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the patches folder?

Copy link
Contributor

@garrettluskey garrettluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go if tests pass

@garrettluskey garrettluskey merged commit 275092a into development Oct 4, 2024
1 of 2 checks passed
@garrettluskey garrettluskey deleted the CharacterObjectLifetime branch October 4, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sync: CharacterObject Lifetime
2 participants