Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where town has no governor assigned (governor = null) #1034

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

georgyrudnev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

Currently there is sometimes a null exception or error when a null value is assigned to the governor in the change town governor handler.

What is the new behavior?

Resolves #

Null value is now handled as well.

Other information

@EgardA EgardA merged commit d555816 into development Nov 20, 2024
2 checks passed
@EgardA EgardA deleted the NoGovernorInTownBugFix branch November 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants