Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TroopRoster Null Data Fix #1029

Merged
merged 2 commits into from
Nov 9, 2024
Merged

TroopRoster Null Data Fix #1029

merged 2 commits into from
Nov 9, 2024

Conversation

garrettluskey
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Troop roster now sets default values in the binary packages

  • this._troopRosterElementsVersion = -1;
  • this._troopRosterElements = new MBList();

Other information

@garrettluskey garrettluskey self-assigned this Nov 9, 2024
@garrettluskey garrettluskey merged commit 5071b66 into development Nov 9, 2024
1 check passed
@garrettluskey garrettluskey deleted the troop-roster-xfer-fix branch November 9, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants