Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settlement Player Enter and Exit Fix #1028

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Conversation

garrettluskey
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Players now enter and exit settlements properly

Other information

@garrettluskey garrettluskey self-assigned this Nov 9, 2024
@garrettluskey garrettluskey marked this pull request as draft November 9, 2024 22:26
@EgardA EgardA marked this pull request as ready for review November 9, 2024 22:34
@garrettluskey garrettluskey merged commit 2f9e8eb into development Nov 9, 2024
1 check passed
@garrettluskey garrettluskey deleted the settlement-bug-fix branch November 9, 2024 22:43
@garrettluskey garrettluskey mentioned this pull request Nov 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants