Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating should effect only the train set #166

Open
JohnGiorgi opened this issue Aug 6, 2019 · 0 comments
Open

Truncating should effect only the train set #166

JohnGiorgi opened this issue Aug 6, 2019 · 0 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@JohnGiorgi
Copy link
Contributor

JohnGiorgi commented Aug 6, 2019

When batching data, Saber truncates / right-pads each sequence to match a length of saber.constants.MAX_SENT_LEN.

Truncating sequences should only happen on the train set, ensuring that we don't drop examples in the evaluation partitions (dataset_folder/valid.* and dataset_folder/test.*)

Furthermore, a user should be able to specify some kind of percentile (e.g. 0.99), which would set the max sequence length to whatever length truncates only 1% of all training examples. This would be a principled way to choose the value. This could lead to big reductions in training time if there were a handful of very long sentences.

@JohnGiorgi JohnGiorgi added the invalid This doesn't seem right label Aug 6, 2019
@JohnGiorgi JohnGiorgi self-assigned this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant