[Android] Increase Target SDK Version API to 28. #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the breaking changes from API 21 to API 28 were made in a way that it doesn't really matter which API your applications targets. That is why there is no risk by increasing API level to 28. This will remove the message about outdated application, and also will remove an issue with the newer phones that have 4k display. It's not possible to increase it further, because starting from API 29 W^X feature was introduced, and this prevent us from running any executable that is not the part of our APK (even the client that we are copying from the assets folder based on the current device architecture). Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5344 +/- ##
============================================
- Coverage 10.87% 10.87% -0.01%
Complexity 1068 1068
============================================
Files 279 279
Lines 36058 36059 +1
Branches 8334 8335 +1
============================================
Hits 3920 3920
- Misses 31744 31745 +1
Partials 394 394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the breaking changes from API 21 to API 28 were made in a way that it doesn't really matter which API your applications targets. That is why there is no risk by increasing API level to 28. This will remove the message about outdated application, and also will remove an issue with the newer phones that have 4k display. It's not possible to increase it further, because starting from API 29 W^X feature was introduced, and this prevent us from running any executable that is not the part of our APK (even the client that we are copying from the assets folder based on the current device architecture).