Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgr: compare best translations for selected languages #5329

Closed
wants to merge 2 commits into from

Conversation

CharlieFenton
Copy link
Contributor

@CharlieFenton CharlieFenton commented Aug 13, 2023

We offer a limited number of translated languages, but the list of possible languages is much larger. Currently, when a user upgrades from an older version BOINC before Automatic Detection of language was offered as a formal option, the Manager decides whether or not to use Automatic Detection by comparing the user's previous language selection with the language which the computer system is set to use. But the translation software picks our closest available translation to the one requested by the user, not necessarily the exact one the user chose.

Old way: compare the actual default language code (the language the system is set to use) with the code for the exact language the user selected from the menu in the Other Options dialog.
New way: compare the actual languages being used by our translation software.

Also, this allows the same code to be used on the Mac as on other platforms.

@BrianNixon Please take a look at this proposed change and let me know what you think.

@CharlieFenton CharlieFenton marked this pull request as draft August 13, 2023 06:48
@CharlieFenton
Copy link
Contributor Author

I am closing this because wxTranslations::GetBestTranslation() does not work the way I thought, so this approach won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant