Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links to labor history and form history #464

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

bledsoef
Copy link
Contributor

Issue Description

Fixes issue #461

  • The link on the student name would link to the form history and there was no way to link to the labor history. We need to make the name link to the labor history and the position title link to form history.

Changes

  • Added a new tag to the student names that links out to their labor history.
  • Moved the modal call over to the position title as that is more intuitive.

Testing

  • Checkout 461_labor_history
  • Reset database (with or without backup data, ideally with backup, though)
  • Execute a search and find a row with a particular student.
  • Click on their name and verify it takes you to their labor history.
  • Click on their position title and verify it takes them to the form's form history.
  • Review code.

@bledsoef bledsoef self-assigned this Nov 22, 2024
@BrianRamsay BrianRamsay merged commit fa1f064 into development Nov 22, 2024
@BrianRamsay BrianRamsay deleted the 461_labor_history branch November 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants