Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer form confirmation 381 #413

Draft
wants to merge 14 commits into
base: development
Choose a base branch
from

Conversation

tylerpar99
Copy link
Member

This pr fixes issue #381

Summary:
The previous LSF creation page had a series of confirmations that seemed redundant to users.

  • This PR has condensed the confirmations to two clicks, an "Add Student" button that will trigger a confirmation modal.
  • We have also changed the old table to a data table that will repopulate with all of the current users created and assigned forms.
  • Lastly, we changed the way cooked were being used on this page so that they will keep the fields populated after a form is created for easier batch adding, we also made sure the cookies from this page and the supervisorPortal work together.

To Test:

  • Set the flask environment to staging, upon page load, you should see forms pre-loaded into the table below. You can then fill out a form for a student and see that after fully adding the form most of the fields will be populated for another add if you choose to do so.
  • If you go to the supervisor portal page and complete a search you should see that the cookies from both pages don't interfere with one another.
  • Run tests suite and make sure everything passes.

@tylerpar99
Copy link
Member Author

The only thing left to do is figure out how to get the position selector to fill from the cookie's data. We tried what we believe to be every combination stack overflow has to offer and have yet to get it successfully fill. My suspicion is that the selector options aren't filling in time and we are essentially attempting to select from an empty list. Brian is looking into it.

@bledsoef
Copy link
Contributor

bledsoef commented Mar 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants