Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add databricks as service in connectivity #905

Closed
wants to merge 1 commit into from
Closed

add databricks as service in connectivity #905

wants to merge 1 commit into from

Conversation

lccc-matt-caswell
Copy link

@lccc-matt-caswell lccc-matt-caswell commented Feb 22, 2024

Overview/Summary

So I've deployed this module recently and was relying on policy to setup dns for private endpoints. Databricks was the only service I couldn't find an existing zone for.

This PR fixes/adds/changes/removes

  1. Add private dns zone for databricks

Breaking Changes

  1. None

Testing Evidence

I can set this up as a private terraform module and test it but I was hoping you'd have unit tests for it. It's not urgent for me to fix this but I thought I'd raise it as a PR to at least see if there was any reason it wasn't in that I am missing or worth adding.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@lccc-matt-caswell
Copy link
Author

@microsoft-github-policy-service agree company="Low Carbon Contracts"

@lccc-matt-caswell
Copy link
Author

/azp run unit

Copy link

Commenter does not have sufficient privileges for PR 905 in repo Azure/terraform-azurerm-caf-enterprise-scale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant