fix: issues with threat_intelligence_allowlist variable type and dynamic block

[heintonny]

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

1. variable type definition for threat_intelligence_allowlist in root module and connectivity module
2. update for_each filter for threat_intelligence_allowlist dynamic block

Correct format of azure_firewall variable should be:

azure_firewall = {
  enabled = false
  config = {
    address_prefix            = "10.0.101.0/24"
    address_management_prefix = "10.0.102.0/24"
    enable_dns_proxy          = true
    dns_servers               = ["8.8.4.4", "..."]
    sku_tier                  = "Standard"
    base_policy_id            = ""
    private_ip_ranges         = ["10.0.103.0/24", "..."]
    threat_intelligence_mode  = "Alert"
    threat_intelligence_allowlist = {
      fqdns        = ["test.blinq.com"]
      ip_addresses = ["1.1.1.1/32"]
    }
    availability_zones = {
      zone_1 = true
      zone_2 = true
      zone_3 = true
    }
  }
}

Breaking Changes

This change should not brake existing configurations

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

+ vwan_hub_networks    = [
    + {
        + config  = {
            + address_prefix                            = "10.20.0.0/16"
            + azure_firewall                            = {
                + config  = {
                    + availability_zones            = {
                        + zone_1 = true
                        + zone_2 = true
                        + zone_3 = true
                      }
                    + base_policy_id                = ""
                    + dns_servers                   = [
                        + "8.8.8.8",
                      ]
                    + enable_dns_proxy              = true
                    + private_ip_ranges             = [
                        + "10.0.0.0/8",
                        + "172.16.0.0/12",
                        + "192.168.0.0/16",
                      ]
                    + sku_tier                      = "Standard"
                    + threat_intelligence_allowlist = {
                        + fqdns        = [
                            + "test.blinq.com",
                          ]
                        + ip_addresses = [
                            + "1.1.1.1/32",
                          ]
                      }
                    + threat_intelligence_mode      = "Alert"
                  }
                + enabled = true
              }

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.

[matt-FFFFFF]

Thank you so much you for this PR - we will look to get this out alongside #885

[matt-FFFFFF]

/azp run unit

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[matt-FFFFFF]

Looks like the test framework needs updating with the new input variable schema

[matt-FFFFFF]

superseded by #907