Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connectivity): custom Settings for Virtual Hub connection names #885

Merged
merged 4 commits into from
Feb 10, 2024
Merged

feat(connectivity): custom Settings for Virtual Hub connection names #885

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1edd79
Add local variables for virtual hub connection resource IDs
birdnathan Jan 5, 2024
2d5e310
Refactor virtual hub connection resource ID generation
birdnathan Feb 5, 2024
cdde43a
Refactor virtual hub connection resource ID and name generation
birdnathan Feb 9, 2024
3f96eba
Merge branch 'main' into 633-vHubConnectionNames
birdnathan Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/connectivity/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1826,10 +1826,16 @@ locals {
for spoke_resource_id in distinct(concat(virtual_hub_config.config.spoke_virtual_network_resource_ids, virtual_hub_config.config.secure_spoke_virtual_network_resource_ids)) :
{
# Resource logic attributes
resource_id = "${local.virtual_hub_resource_id[location]}/hubVirtualNetworkConnections/peering-${uuidv5("url", spoke_resource_id)}"
resource_id = try(
"${local.virtual_hub_resource_id[location]}/hubVirtualNetworkConnections/${local.custom_settings.azurerm_virtual_hub_connection["virtual_wan"][location][spoke_resource_id].name}",
"${local.virtual_hub_resource_id[location]}/hubVirtualNetworkConnections/peering-${uuidv5("url", spoke_resource_id)}"
)
managed_by_module = local.deploy_virtual_hub_connection[location]
# Resource definition attributes
name = "peering-${uuidv5("url", spoke_resource_id)}"
name = try(
local.custom_settings.azurerm_virtual_hub_connection["virtual_wan"][location][spoke_resource_id].name,
"peering-${uuidv5("url", spoke_resource_id)}"
)
virtual_hub_id = local.virtual_hub_resource_id[location]
remote_virtual_network_id = spoke_resource_id
# Optional definition attributes
Expand Down