Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italy North and avoid casing issues #834

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Oct 6, 2023

Overview/Summary

This PR adds Italy North as a supported region.

It also helps with case sensitivity in the locations for networking, to avoid errors related to the casing of the location supplied in variables.

This PR fixes/adds/changes/removes

  1. Italynorth as default_location #833

Breaking Changes

None

Testing Evidence

E2E and Unit Tests have been run in this PR. The test input location casing has been updated such that they would have broken the tests prior to this update.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate
Copy link
Member Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredfholgate
Copy link
Member Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredfholgate
Copy link
Member Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredfholgate jaredfholgate marked this pull request as ready for review October 6, 2023 15:43
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cheers Jared

@jaredfholgate
Copy link
Member Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredfholgate
Copy link
Member Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredfholgate jaredfholgate merged commit 068d939 into main Oct 7, 2023
28 checks passed
@jaredfholgate jaredfholgate deleted the 833-italynorth-as-default_location branch October 7, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants