Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug vpn client config #792

Closed
wants to merge 10 commits into from
Closed

Conversation

gogondi1
Copy link
Contributor

Overview/Summary

unable to configure vpn_client_configuration due to revoked_certificate block defined with wrong parameters #791

in hub and spoke model when try to configure vpn_client_configuration under virtual_network_gateway, error is receiving due to one of the parameter under revoked_certificate is wrong, public_cert_data under revoked_certificate block need to replace by "thumbprint" according to terraform documentation.

[Screenshot 2023-08-16 at 14 55 12(url)

This PR fixes/adds/changes/removes

  1. you can configure vpn_client_config successfully

Breaking Changes

  1. if issue with current modification replace thumbprint with public_cert_data

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

[Screenshot 2023-08-17 at 15 36 42(url)

[Screenshot 2023-08-17 at 15 34 16(url)

As part of this Pull Request I have

  • [x ] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant issues, for tracking and closure.
  • [x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x ] Performed testing and provided evidence.
  • [x ] Updated relevant and associated documentation.

@gogondi1
Copy link
Contributor Author

@microsoft-github-policy-service agree

.github/policies/cla.yml Outdated Show resolved Hide resolved
.github/policies/platformcontext.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@gogondi1 gogondi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have delete cla.yml and platformcontext.yml files, could anyone please review

Copy link
Contributor Author

@gogondi1 gogondi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I request to review the changes and merge the branches

@matt-FFFFFF
Copy link
Member

Thank you for this pr - since I could not push to your fork to update from main, I pulled your changes into a new branch that I can work on. Therefore closing in favour of #835

@matt-FFFFFF matt-FFFFFF closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants