feat: november 2024 release #1201
Merged
+958
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated 'pull_request' containing updates to the library templates stored in 'modules/archetypes/lib'. Please review the 'files changed' tab to review changes. Co-authored-by: github-actions <action@github.com>
<!-- markdownlint-disable first-line-h1 --> <!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary This is a short PR to update `locals.geo_codes.tf.json`, to support the new Azure regions launched in the last year or so (Brazil US, Spain Central, Israel Central, Mexico Central, New Zealand North, and Poland Central). I've used the ISO 3166 codes, and thankfully there aren't any clashes with existing, or 'informal' shortcodes. ## As part of this Pull Request I have - [X] Checked for duplicate [Pull Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls) - [N/A] Associated it with relevant [issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues), for tracking and closure. - [X] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main) - [N/A] Performed testing and provided evidence. - [N/A] Updated relevant and associated documentation.
<!-- markdownlint-disable first-line-h1 --> <!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary Replace this with a brief description of what this Pull Request fixes, changes, etc. ## This PR fixes/adds/changes/removes 1. Fixes #1135 - Race condition results in InternalServerError when deploying in vhub a firewall, an express route gateway, vhub peering and routing intent 2. Fixes #1136 - Updating existing vnet dns_server with Azure firewall leads to azurerm_virtual_network error. 3. *Replace me* ### Breaking Changes none ## Testing Evidence ``` module.alz_connectivity.azurerm_virtual_hub_routing_intent.virtual_wan["/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/lz-cl-routingintent-southeastasia"]: Still creating... [6m40s elapsed] module.alz_connectivity.azurerm_virtual_hub_routing_intent.virtual_wan["/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/lz-cl-routingintent-southeastasia"]: Creation complete after 6m41s [id=/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/routingIntent/lz-cl-routingintent-southeastasia] Apply complete! Resources: 178 added, 0 changed, 0 destroyed. ``` Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate). ## As part of this Pull Request I have - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls) - [x] Associated it with relevant [issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues), for tracking and closure. - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main) - [x] Performed testing and provided evidence. - [x] Updated relevant and associated documentation.
setting `retention_in_days` worked OK, but setting `daily_quota_gb` did
not. We configured the daily cap from the Azure Portal but this
automation rolls it back to be disabled. This PR makes it so we can set
a value for our environment, and it is not rolled back.
```terraform
# module.alz.azurerm_log_analytics_workspace.management["/subscriptions/96f9ca86-6842-4c2f-aada-2daafa1b0b9c/resourceGroups/redpanda-mgmt/providers/Microsoft.OperationalInsights/workspaces/redpanda-la"] will be updated in-place
~ resource "azurerm_log_analytics_workspace" "management" {
~ daily_quota_gb = 64 -> -1
id = "/subscriptions/96f9ca86-6842-4c2f-aada-2daafa1b0b9c/resourceGroups/redpanda-mgmt/providers/Microsoft.OperationalInsights/workspaces/redpanda-la"
name = "redpanda-la"
tags = {
"deployedBy" = "terraform/azure/caf-enterprise-scale"
"redpanda-org" = "azure-governance"
}
# (14 unchanged attributes hidden)
}
```
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Landing Zones policy refresh https://github.com/Azure/Enterprise-Scale/releases/tag/2024-11-05
And other minor improvements:
This PR fixes/adds/changes/removes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
mainbranch