This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Fixing the elevator model #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The healthy elevator doesn't move. Moving is set to true in the JS, but not set in the JSON so false is winning.
peterfelts
suggested changes
Oct 25, 2019
| @@ -12,7 +12,8 @@ | |||
| "vibration": 10.0, | |||
| "vibration_unit": "mm", | |||
| "temperature": 75.0, | |||
| "temperature_unit": "F" | |||
| "temperature_unit": "F", | |||
| "moving": true | |||
There was a problem hiding this comment.
This change makes me think that we don't even use/consume the default state in the JS files here and here when state values are provided in the device-model files.
It would be great if this change included a comment in all the JS files that called out that we don't respect these default values if they're provided in the device model (I assume that is why you added the value here).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
...
Change type
Checklist: