Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Improved gps location device simulation #159

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

joelhulen
Copy link

@joelhulen joelhulen commented Jan 22, 2018

Type of change?

  • Bug fix
  • New feature
  • Enhancement
  • Breaking change (breaks backward compatibility)

Description, Context, Motivation

The previous version never actually changed the truck's location after the first pass. This version randomizes the changed distance, plus it adds a rounding function that handles the positive and negative values of the lat/long coordinates equally well. This results in an improved randomized route for the trucks. Not 100% realistic (data would need to be incorporated for that), but good enough for a simulation.

Checklist:

  • All tests passed
  • The code follows the code style and conventions of this project
  • The change requires a change to the documentation
  • I have updated the documentation accordingly

This change is Reviewable

The previous version never actually changed the truck's location after the first pass. This version randomizes the changed distance, plus it adds a rounding function that handles the positive and negative values of the lat/long coordinates equally well. This results in an improved randomized route for the trucks. Not 100% realistic (data would need to be incorporated for that), but good enough for a simulation.
Improved gps location simulation
@dluc
Copy link
Member

dluc commented Jan 22, 2018

@joelhulen thanks for the PR, we're looking into it

@dluc
Copy link
Member

dluc commented May 12, 2018

@peterfelts could you look at this PR?

@dluc dluc requested a review from hathind-ms as a code owner October 18, 2018 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants