Search tsp #31123
Search tsp #31123
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
|
@xiangyan99 the typespec validation and typespec apiview steps need to be passing as well |
There was a problem hiding this comment.
Thanks for cleaning up the spec, it's looking good. We do need to get the CI checks resolved. This page could help figure out any issues: aka.ms/ci-fix
| /** The discriminator for derived types. */ | ||
| #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing" | ||
| @encodedName("application/json", "@odata.type") | ||
| odataType: string; |
There was a problem hiding this comment.
Should this have a visibility read on it then?
| model SearchIndexerKnowledgeStoreObjectProjectionSelector | ||
| extends SearchIndexerKnowledgeStoreBlobProjectionSelector {} |
There was a problem hiding this comment.
I'm wondering if this will cause issues when generating in certain languages. If the SearchIndexerKnowledgeStoreBlobProjectionSelector model is the same as the base model then what's the benefit of having is?
Could this have just been a mistake in the handwritten swagger?
| * The format of the synonym map. Only the 'solr' format is currently supported. | ||
| */ | ||
| format: "solr"; |
There was a problem hiding this comment.
Since the description says "currently" do we think there will be other values in the future? Should this be an enum instead?
| * Response from a List Indexes request. If successful, it includes the full | ||
| * definitions of all indexes. | ||
| */ | ||
| @pagedResult |
There was a problem hiding this comment.
There's no nextLink property for this model?
| * The list of field names to use for hit highlights. Only searchable fields can | ||
| * be used for hit highlighting. | ||
| */ | ||
| @query(#{ |
There was a problem hiding this comment.
It was hinted by the compiler.
Deprecated: Using a model as a value is deprecated. Use an object value instead(with #{}).
There was a problem hiding this comment.
Looks like these openapi specs should be checked in under the existing Azure.Search directory?
There was a problem hiding this comment.
When I ran tsp compile, these files were auto generated. Could you tell me where is the right place to put them?
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.