Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require passing owner and repo names to upload_sarif_to_github #121

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Don't require passing owner and repo names to upload_sarif_to_github #121

merged 2 commits into from
Sep 17, 2024

Conversation

wzieba
Copy link
Member

@wzieba wzieba commented Sep 16, 2024 •
edited
Loading

We can extract this data from Buildkite

Proof that it works: Automattic/pocket-casts-android#2866 (specifically: https://buildkite.com/automattic/pocket-casts-android/builds/8387#0191fa68-20ce-4458-a78c-2f1e899372d7/179-248)

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@wzieba wzieba added the enhancement New feature or request label Sep 16, 2024
@wzieba wzieba marked this pull request as ready for review September 16, 2024 10:49
iangmaia
iangmaia approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@iangmaia iangmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wzieba wzieba merged commit e07d437 into trunk Sep 17, 2024
16 checks passed
@wzieba wzieba deleted the do_not_require_repo_owner branch September 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iangmaia iangmaia iangmaia approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzieba @iangmaia