Functions/RestrictedFunctions: remove reference to function which doe…

…sn't exist PHP does not contain a `delete()` function, so searching for it will only yield false positives. Ref: https://www.php.net/manual/en/function.delete.php
Automattic · Aug 22, 2023 · 756b1a5 · 756b1a5
1 parent df070e7
commit 756b1a5
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 9 deletions.
diff --git a/WordPress-VIP-Go/ruleset-test.inc b/WordPress-VIP-Go/ruleset-test.inc
@@ -1,7 +1,7 @@
 <?php
 $file = ''; $fp = ''; $dir = ''; $test = ''; $bar = ''; $array = []; $query_args = []; $url = ''; $query = ''; $page_title = ''; $true = true; $some_nasty_var = ''; $data = ''; $group = ''; $testing = ''; $needle = ''; $some_var = ''; $blogid = 1; $text = ''; $category_id = 123; $foo = ''; $bar = ''; $var = ''; $wp_rewrite = ''; $count = 1; $loop = 1; $a = ''; $b = ''; $obj = ''; // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- All set for VariableAnalysis checks.
-// WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_delete
-delete( $file ); // Warning + Message.
+// WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_unlink
+unlink( $file ); // Warning + Message.
 
 // WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_file_put_contents
 file_put_contents( 'file.txt', '', FILE_APPEND ); // Warning + Message.
@@ -388,7 +388,7 @@ session_status(); // Error.
 session_unregister(); // Error.
 session_unset(); // Error.
 session_write_close(); // Error.
-delete(); // Warning.
+unlink(); // Warning.
 file_put_contents( $file, $text, FILE_APPEND ); // Warning.
 while ( $count > $loop ) {
 	if ( flock( $fp, LOCK_EX ) ) { // Warning.

diff --git a/WordPress-VIP-Go/ruleset-test.php b/WordPress-VIP-Go/ruleset-test.php
@@ -238,7 +238,7 @@
 	],
 	'messages' => [
 		4   => [
-			'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()`  or `wp_get_upload_dir()` to get the proper directory path when using functions such as delete(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/',
+			'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()`  or `wp_get_upload_dir()` to get the proper directory path when using functions such as unlink(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/',
 		],
 		7   => [
 			'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()`  or `wp_get_upload_dir()` to get the proper directory path when using functions such as file_put_contents(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/',

diff --git a/WordPress-VIP-Go/ruleset.xml b/WordPress-VIP-Go/ruleset.xml
@@ -7,7 +7,7 @@
 	<rule ref="WordPressVIPMinimum"/>
 
 	<!-- Things that may be incompatible with the VIP Go infrastructure and needs a dev to review -->
-	<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_delete">
+	<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.file_ops_unlink">
 		<type>warning</type>
 		<severity>6</severity>
 		<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()`  or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/</message>

diff --git a/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php b/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php
@@ -187,7 +187,6 @@ public function getGroups() {
 				'type'      => 'error',
 				'message'   => 'Filesystem writes are forbidden, please do not use %s().',
 				'functions' => [
-					'delete',
 					'file_put_contents',
 					'flock',
 					'fputcsv',

diff --git a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc
@@ -179,7 +179,7 @@ while ( $count > $loop ) {
 
 fclose( $fp ); // Ok.
 
-delete(); // Error.
+
 fputcsv(); // Error.
 fputs(); // Error.
 ftruncate(); // Error.

diff --git a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php
@@ -82,7 +82,6 @@ public function getErrorList() {
 			174 => 1,
 			175 => 1,
 			177 => 1,
-			182 => 1,
 			183 => 1,
 			184 => 1,
 			185 => 1,

diff --git a/WordPressVIPMinimum/ruleset-test.inc b/WordPressVIPMinimum/ruleset-test.inc
@@ -365,7 +365,7 @@ session_status(); // Error.
 session_unregister(); // Error.
 session_unset(); // Error.
 session_write_close(); // Error.
-delete(); // Error.
+unlink(); // Error.
 file_put_contents( $file, $text, FILE_APPEND ); // Error.
 while ( $count > $loop ) {
 	if ( flock( $fp, LOCK_EX ) ) { // Error.