#135 Support more ways to create beans (e.g. Java records) #398
Conversation
src/main/java/ch/jalu/configme/beanmapper/instantiation/BeanInstantiationService.java
Show resolved
Hide resolved
src/main/java/ch/jalu/configme/beanmapper/instantiation/BeanInstantiationServiceImpl.java
Show resolved
Hide resolved
src/main/java/ch/jalu/configme/beanmapper/instantiation/BeanInstantiationServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/jalu/configme/internal/record/ReflectionHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/jalu/configme/beanmapper/instantiation/BeanInstantiationServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/jalu/configme/beanmapper/instantiation/BeanInstantiationServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/jalu/configme/beanmapper/propertydescription/BeanDescriptionFactory.java
Show resolved
Hide resolved
ljacqu
force-pushed
the
135-support-data-classes-draft
branch
from
68bfefe
to
0a8e9bd
Compare
| protected @NotNull List<BeanPropertyDescription> getBeanProperties(@NotNull Object value) { | ||
| return beanInstantiationService.findInstantiation(value.getClass()) | ||
| .map(BeanInstantiation::getProperties) | ||
| .orElse(Collections.emptyList()); |
There was a problem hiding this comment.
Interesting to note that here a bean instantiation is retrieved during the export to find out what properties it has. Maybe "instantiation" is not a good name? No better idea at the time of writing
...t/java/ch/jalu/configme/beanmapper/propertydescription/BeanFieldPropertyDescriptionTest.java
Outdated
Show resolved
Hide resolved
| private String name; // Ignore name of parent | ||
|
|
||
| @ExportName("o_ratio") | ||
| private float ratio; // Override name of Middle#ratio |
There was a problem hiding this comment.
The Wiki should have an example like this
There was a problem hiding this comment.
Check behavior when a class has no bean instantiation: I think there was some weird behavior. Mapping should be stopped.
| * <p> | ||
| * Default implementation is {@link BeanPropertyDescriptionImpl}. | ||
| * Default implementation of this interface is {@link BeanFieldPropertyDescription}. | ||
| */ | ||
| public interface BeanPropertyDescription { |
There was a problem hiding this comment.
Still not fully happy with the names here. Is Description right? Should it be just BeanComponent?
What about the BeanDescriptionFactory?
There was a problem hiding this comment.
Probably need to create another issue to change the mapping context. It should be able to have more info to support generic types in the future.
No description provided.