Download File Progress #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The progress is reporting the number of downloaded pieces, which can be larger than 100. To download the progress in percentage (ranging from 0 to 100) devide size downloaded size by total file size and multiply by 100 (for percentage). Use Math.Floor to not report a progress of 100 when a byte is still missing.
Berkel256
commented
Nov 11, 2024
| @@ -370,7 +370,7 @@ private static async Task HttpDownloadWithStreamAsync(HttpClient client, Uri uri | |||
| { | |||
| await fs.WriteAsync(buffer, 0, bytesRead); | |||
| newResumeSize += bytesRead; | |||
| progress?.Report((int)(newResumeSize * pieces / totalFileLengths)); | |||
| progress?.Report((int)Math.Floor(newResumeSize / totalFileLengths * 100)); | |||
There was a problem hiding this comment.
make sure that this is actually compiling because of type conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress is reporting the number of downloaded pieces, which can be larger than 100. To download the progress in percentage (ranging from 0 to 100) devide size downloaded size by total file size and multiply by 100 (for percentage). Use Math.Floor to not report a progress of 100 when a byte is still missing.