This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix import find gap querying limit #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could be, as it's a defer'd sequence, it will paginate until the end, otoh, this doctor namespace, wasn't entierly production ready, not sure it's even used atm. |
hlolli
reviewed
Feb 20, 2022
| )(blockQ.rows as { block_height: CassandraTypes.Long }[]); | ||
| if (findResult < 0) { | ||
| missingHeights.push(height); | ||
| for (const subHeightGroup of queryHeightSubGroups) { |
There was a problem hiding this comment.
hats off for using Ramda functions!
could we use for-await here and have the pagination be done automatically, just thinking.
There was a problem hiding this comment.
Sure will come back to this when I have some spare time...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cassandra-drive has a limit of 5000 result per query, so only first 5000 block would be returned
https://github.com/datastax/nodejs-driver#paging