Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] Select an album item automatically if an artist only contains 1 AlbumItem in Zune Shell. #236

Merged
merged 14 commits into from
Jul 14, 2023

Conversation

amaid
Copy link
Collaborator

@amaid amaid commented Sep 23, 2022

Overview

In Progress #129

Following the zune desktop app, if an artist has only one albumitem in the album collection select it automatically from the album collection.

2022-09-23.12-25-34.mp4

Checklist

This PR meets the following requirements:

  • Tested and contains NO breaking changes or known regressions.
  • Tested with the upstream branch merged in.
  • Tests have been added for bug fixes / features (or this option is not applicable)
  • All new code has been documented (or this option is not applicable)
  • Headers have been added to all new source files (or this option is not applicable)

Additional info

Not provided

@amaid amaid added the enhancement New feature or request label Sep 23, 2022
Copy link
Owner

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doesn't deselect when moving between albums.

There's a lot of bugs with album selection state when moving between artists that I hadn't noticed before.
Let's save this for after the big refactor.

@Arlodotexe Arlodotexe added this to the Road to 0.2.0 milestone May 13, 2023
@amaid
Copy link
Collaborator Author

amaid commented Jun 11, 2023

Looks like this doesn't deselect when moving between albums.

There's a lot of bugs with album selection state when moving between artists that I hadn't noticed before. Let's save this for after the big refactor.

The deselection issue has been fixed, re the second one, zune shell CollectionContent has been refactored to use SwitchPresenter instead of relying on the visual states. This has fixed most of the major bugs.

Copy link
Owner

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found just one issue in testing - items that are added to the collection after load don't get the correct visual state applied.

Recording.2023-06-12.040311.mp4

@amaid
Copy link
Collaborator Author

amaid commented Jun 24, 2023

Found just one issue in testing - items that are added to the collection after load don't get the correct visual state applied.

Recording.2023-06-12.040311.mp4

This was fixed in the latest commit.

@Arlodotexe Arlodotexe merged commit 70f4f55 into main Jul 14, 2023
@Arlodotexe Arlodotexe deleted the feature/auto-album-selection branch July 14, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants