-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] Select an album item automatically if an artist only contains 1 AlbumItem in Zune Shell. #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this doesn't deselect when moving between albums.
There's a lot of bugs with album selection state when moving between artists that I hadn't noticed before.
Let's save this for after the big refactor.
The deselection issue has been fixed, re the second one, zune shell CollectionContent has been refactored to use SwitchPresenter instead of relying on the visual states. This has fixed most of the major bugs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found just one issue in testing - items that are added to the collection after load don't get the correct visual state applied.
Recording.2023-06-12.040311.mp4
src/Shells/StrixMusic.Shells.ZuneDesktop/Controls/Views/Items/ZuneAlbumItem.cs
Outdated
Show resolved
Hide resolved
…ZuneAlbumItem.cs Co-authored-by: Arlo <arlo.godfrey@outlook.com>
This was fixed in the latest commit. |
Overview
In Progress #129
Following the zune desktop app, if an artist has only one albumitem in the album collection select it automatically from the album collection.
2022-09-23.12-25-34.mp4
Checklist
This PR meets the following requirements:
Additional info
Not provided